This PR should probably be integrated in next release.

Hopefully I can test that the minidump contains good information before the release is published.

I plan to make sure this builds fine the way Dale and I build. today or tomorrow.

UPDATE: I tried to analyse my minidump with windbg tool. It gives some information about the exception but because we build with mingw and not MSVC, the .debug file cannot be used by windbg to fully unveil it's potential. However the minidump contains a stacktrace that we could possibly analyse with addr2line (for the "wave front inspector" crash there was no meaningful info so I'm really not sure)

I see 2 path of action:

• integrate this PR and keep minidump as it doesn't harm.
• remove the minidump thing. But keep SetUnhandledExceptionFilter to at least try to log something in a text file and not have silent crash (spdlog doesn't work in this context)

I would lean for the first. What do you think ?

I don't have an opinion so I'll trust you to choose.

@atsju did you see my comment above?

@atsju did you see my comment above?

I did see. I did not decide.
On one side it doesn't harm. On the other side, it's one more rarely used (and thus untested) feature.

Let's keep it and see if it brings something on futur crashes

Maybe I wasn't clear in the comments above. This won't compile for me because you added something to the "normal" .pro file but forgot to add it to the dale .pro file. That's why I haven't approved this PR yet.

Maybe I wasn't clear in the comments above. This won't compile for me because you added something to the "normal" .pro file but forgot to add it to the dale .pro file. That's why I haven't approved this PR yet.

I get it now. I will fix it.

Okay so I made the same mistake dale did. I did an inline comment among the code changes and wondered why Julien ignored it. Anyway he took care of it so this is ready to merge.